Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate image generation matrices #5815

Merged
merged 2 commits into from
Jun 21, 2024
Merged

consolidate image generation matrices #5815

merged 2 commits into from
Jun 21, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jun 21, 2024

Proposed changes

This change makes json file the single source of truth for building the different images. This is to address cases where some images were not built/published in previous features.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner June 21, 2024 13:04
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 21, 2024
@oseoin oseoin enabled auto-merge (squash) June 21, 2024 13:18
@oseoin oseoin merged commit d073aa6 into main Jun 21, 2024
80 checks passed
@oseoin oseoin deleted the image-matrices branch June 21, 2024 13:42
oseoin pushed a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants