Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcode for NIC version in docs #5953

Merged
merged 11 commits into from
Jul 5, 2024
Merged

Shortcode for NIC version in docs #5953

merged 11 commits into from
Jul 5, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jul 4, 2024 •
edited
Loading

Proposed changes

Move version numbers to Hugo shortcodes to avoid large repeated PRs every release.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation chore Pull requests for routine tasks labels Jul 4, 2024
@oseoin oseoin marked this pull request as ready for review July 4, 2024 10:12
@oseoin oseoin requested review from a team as code owners July 4, 2024 10:12
pdabelf5
pdabelf5 reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write the shortcode files from the Docs PR workflow?

Maybe extend the Docs PR workflow and add operator version to it

@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Jul 4, 2024
@ADubhlaoich ADubhlaoich mentioned this pull request Jul 4, 2024
Merged
6 tasks
@oseoin oseoin enabled auto-merge (squash) July 5, 2024 14:34
@oseoin oseoin added the needs cherry pick Cherry pick this PR into a release branch label Jul 5, 2024
@oseoin oseoin merged commit 6f8709f into main Jul 5, 2024
79 checks passed
@oseoin oseoin deleted the docs-version branch July 5, 2024 14:37
pdabelf5 pushed a commit that referenced this pull request Jul 5, 2024
@oseoin @pdabelf5
Shortcode for NIC version in docs (#5953)
0340097
oseoin added a commit that referenced this pull request Jul 5, 2024
@nginx-bot @oseoin
[cherry-pick] Shortcode for NIC version in docs (#5975)
92352e4 
Shortcode for NIC version in docs (#5953)

Co-authored-by: oseoin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@oseoin @ADubhlaoich @haywoodsh @j1m-ryan @AlexFenlon @jjngx @pdabelf5