Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add security note about JWT and passwords in shell history #6011

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jul 11, 2024

Proposed changes

As noted in the linked GitHub issue, I've set up a modified version of https:/nginxinc/docs-platform/issues/156#issuecomment-2221084455 in an "include," and added it to the relevant docs in this repository.

This change is functionally identical to https:/nginxinc/docs/pull/990

GitHub Issue:
Partially closes https:/nginxinc/docs-platform/issues/156

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@mjang mjang requested review from a team as code owners July 11, 2024 17:51
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 11, 2024
@travisamartin
Copy link
Contributor

I previewed the build locally and the updates look great. Thanks! :)

@mjang mjang merged commit aef49fe into main Jul 15, 2024
52 checks passed
@mjang mjang deleted the mjang-include-jwt-password-note branch July 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants