Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: broken links #6216

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix: broken links #6216

merged 1 commit into from
Aug 16, 2024

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Aug 15, 2024

Proposed changes

Request via @chrisakker to fix links on this README. I'm going to also need an update to the second to last link in the file, which is the blog post still available here: http://web.archive.org/web/20200809142432/https://www.nginx.com/blog/nginx-ingress-controller-ibm-cloud-private/

(We need it in an f5.com URL)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@mjang mjang self-assigned this Aug 15, 2024
@mjang mjang requested a review from a team as a code owner August 15, 2024 18:07
@mjang mjang marked this pull request as draft August 15, 2024 18:07
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Aug 15, 2024
@mjang mjang force-pushed the fix-mjang-broken-links-cust-id branch from 16f0f21 to a1fb3bd Compare August 16, 2024 15:38
@mjang mjang force-pushed the fix-mjang-broken-links-cust-id branch from a1fb3bd to 57bfda4 Compare August 16, 2024 15:39
@mjang mjang marked this pull request as ready for review August 16, 2024 15:40
@mjang
Copy link
Contributor Author

mjang commented Aug 16, 2024

I see I have approvals, thanks.

Since it might be a while before we get the republished blog post, I've commented out that line, and will proceed with merging this PR. @chrisakker , the 2nd to last link goes to an NGINX blog post that was missed in the move to f5.com. I'll set up a new PR as soon as I get an update.

@mjang mjang merged commit 25a8dd1 into main Aug 16, 2024
76 checks passed
@mjang mjang deleted the fix-mjang-broken-links-cust-id branch August 16, 2024 16:06
@pdabelf5 pdabelf5 removed the helm_chart Pull requests that update the Helm Chart label Sep 23, 2024
@pdabelf5 pdabelf5 changed the title fix: broken links Fix: broken links Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants