Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated use cases from Helm installation documentation #6279

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Aug 23, 2024

Proposed changes

This commit removes the "Notes" section from the Helm installation document, which mentioned an IBM Cloud use case not developed since 2018, and NGINX Service Mesh, which went EOS last year.

It also updates some content to be adherent with contemporary standards, and shifts some context-specific NGINX App DoS information to the relevant page.

Closes #6273.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit removes the "Notes" section from the Helm installation
document, which mentioned an IBM Cloud use case not developed since
2018, and NGINX Service Mesh, which went EOS last year.

It also updates some content to be adherent with contemporary standards,
and shifts some context-specific NGINX App DoS information to the
relevant page.
@ADubhlaoich ADubhlaoich requested review from a team as code owners August 23, 2024 09:42
@ADubhlaoich ADubhlaoich self-assigned this Aug 23, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 23, 2024
@ADubhlaoich ADubhlaoich linked an issue Aug 23, 2024 that may be closed by this pull request
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6279/

@ADubhlaoich ADubhlaoich enabled auto-merge (squash) August 23, 2024 13:15
@ADubhlaoich ADubhlaoich merged commit fa1e037 into main Aug 23, 2024
30 checks passed
@ADubhlaoich ADubhlaoich deleted the remove-unsupported-cases branch August 23, 2024 13:16
ADubhlaoich added a commit that referenced this pull request Aug 23, 2024
This commit removes the "Notes" section from the Helm installation
document, which mentioned an IBM Cloud use case not developed since
2018, and NGINX Service Mesh, which went EOS last year.

It also updates some content to be adherent with contemporary standards,
and shifts some context-specific NGINX App DoS information to the
relevant page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Include info on values-icp..yaml, original in a blog post
4 participants