Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert version from log and chart #6307

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Assert version from log and chart #6307

merged 3 commits into from
Aug 29, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 29, 2024 •
edited
Loading

Proposed changes

  • check if NIC version form chart.yaml is same as one form logs

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner August 29, 2024 11:19
@github-actions github-actions bot added python Pull requests that update Python code github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks tests Pull requests that update tests labels Aug 29, 2024
@vepatel vepatel removed the chore Pull requests for routine tasks label Aug 29, 2024
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 29, 2024
@vepatel vepatel enabled auto-merge (squash) August 29, 2024 11:48
@vepatel vepatel merged commit 81bcf96 into main Aug 29, 2024
77 checks passed
@vepatel vepatel deleted the tests/update-build-info branch August 29, 2024 12:20
@pdabelf5 pdabelf5 changed the title assert version from log and chart Assert version from log and chart Sep 23, 2024
@pdabelf5 pdabelf5 removed python Pull requests that update Python code github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @j1m-ryan @pdabelf5