Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor GlobalConfiguration controller #6327

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Sep 2, 2024

Proposed changes

This change moves the Global Configuration controller code to it's own file to help reduce the complexity of controller.go.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner September 2, 2024 16:03
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 2, 2024
@pdabelf5 pdabelf5 changed the title refactor EndpointSlice controllermove global_configuration functions to their own file refactor GlobalConfiguration controller Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 104 lines in your changes missing coverage. Please review.

Project coverage is 53.04%. Comparing base (fbeed76) to head (ffd40bb).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/global_configuration.go 0.00% 104 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6327      +/-   ##
==========================================
+ Coverage   53.01%   53.04%   +0.02%     
==========================================
  Files          79       80       +1     
  Lines       15921    15921              
==========================================
+ Hits         8441     8445       +4     
+ Misses       7073     7071       -2     
+ Partials      407      405       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vepatel vepatel self-requested a review September 3, 2024 08:09
@pdabelf5 pdabelf5 enabled auto-merge (squash) September 4, 2024 08:09
@pdabelf5 pdabelf5 merged commit 6178324 into main Sep 4, 2024
76 checks passed
@pdabelf5 pdabelf5 deleted the controller-gc-refactor branch September 4, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants