Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove extra endifs #6352

Merged
merged 1 commit into from
Sep 4, 2024
Merged

remove extra endifs #6352

merged 1 commit into from
Sep 4, 2024
+0 −2

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 4, 2024 •
edited
Loading

Proposed changes

  • remove extra endif statements causing Makefile:25: *** extraneous 'endif'. Stop. on make docs

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners September 4, 2024 15:24
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6352/

@ADubhlaoich ADubhlaoich added the needs cherry pick Cherry pick this PR into a release branch label Sep 4, 2024
@vepatel vepatel merged commit 27fb090 into main Sep 4, 2024
30 checks passed
@vepatel vepatel deleted the docs/remove-extra-endifs branch September 4, 2024 15:30
nginx-bot pushed a commit that referenced this pull request Sep 4, 2024
@vepatel @web-flow
remove extra endifs (#6352)
18e770f
@vepatel vepatel self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees

@vepatel vepatel

Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @ADubhlaoich @j1m-ryan