Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go v1.23 alpine as golang_builder #6392

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Use Go v1.23 alpine as golang_builder #6392

merged 1 commit into from
Sep 11, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Sep 11, 2024

Proposed changes

This PR updated Golang builder image to Go v1.23 (1.23-alpine)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner September 11, 2024 13:18
@github-actions github-actions bot added the docker Pull requests that update Docker code label Sep 11, 2024
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Sep 11, 2024
@jjngx jjngx merged commit 200d074 into main Sep 11, 2024
78 checks passed
@jjngx jjngx deleted the chore/go-version branch September 11, 2024 13:48
nginx-bot pushed a commit that referenced this pull request Sep 11, 2024
@jjngx @web-flow
Use Go v1.23 alpine as golang_builder (#6392)
ce0f27d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
docker Pull requests that update Docker code needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjngx @j1m-ryan @vepatel @pdabelf5