Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Service Controller to it's own file #6395

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Sep 11, 2024

Proposed changes

refactor Service Controller to it's own file

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner September 11, 2024 14:44
@pdabelf5 pdabelf5 self-assigned this Sep 11, 2024
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 84 lines in your changes missing coverage. Please review.

Project coverage is 53.23%. Comparing base (cc7e466) to head (671bbf0).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/service.go 14.28% 82 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6395      +/-   ##
==========================================
+ Coverage   53.20%   53.23%   +0.02%     
==========================================
  Files          83       85       +2     
  Lines       16002    16002              
==========================================
+ Hits         8514     8518       +4     
+ Misses       7081     7079       -2     
+ Partials      407      405       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) September 12, 2024 10:51
@pdabelf5 pdabelf5 merged commit f6f0aaa into main Sep 12, 2024
80 checks passed
@pdabelf5 pdabelf5 deleted the controller_service_rafactor branch September 12, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants