Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message to comply with staticcheck #6421

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix error message to comply with staticcheck #6421

merged 1 commit into from
Sep 13, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Sep 13, 2024

Proposed changes

This PR fixes staticcheck error: pkg/apis/dos/validation/dos.go:206:11: error strings should not be capitalized (ST1005)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner September 13, 2024 14:08
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.23%. Comparing base (45d3f46) to head (d8e5870).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6421   +/-   ##
=======================================
  Coverage   53.23%   53.23%           
=======================================
  Files          85       85           
  Lines       16002    16002           
=======================================
  Hits         8518     8518           
  Misses       7079     7079           
  Partials      405      405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx merged commit 0d57f94 into main Sep 13, 2024
80 checks passed
@jjngx jjngx deleted the chore/error-fix branch September 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants