Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/transport server sni #6605

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Feat/transport server sni #6605

wants to merge 30 commits into from

Conversation

j1m-ryan
Copy link
Member

@j1m-ryan j1m-ryan commented Oct 7, 2024

Proposed changes

TransportServer SNI
#6324

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.49%. Comparing base (b4183ea) to head (7be8dc2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/configurator.go 50.00% 0 Missing and 1 partial ⚠️
internal/k8s/configuration.go 98.24% 1 Missing ⚠️
...g/apis/configuration/validation/transportserver.go 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6605      +/-   ##
==========================================
+ Coverage   53.29%   53.49%   +0.20%     
==========================================
  Files          87       87              
  Lines       16277    16318      +41     
==========================================
+ Hits         8675     8730      +55     
+ Misses       7187     7168      -19     
- Partials      415      420       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6605/

@j1m-ryan j1m-ryan marked this pull request as ready for review October 11, 2024 14:17
@j1m-ryan j1m-ryan requested review from a team as code owners October 11, 2024 14:17
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have a lot of edit suggestions.

Ordered list enumeration (1. repeated) is only available when writing a Hugo page.

It's very basic, but since explicit instructions are given for everything else, the example could also give the command to view the logs.

I may convert this to a proper documentation page at a later point: see #6572 for an example.

examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
examples/custom-resources/transport-server-sni/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests
Projects
Status: Todo ☑
Development

Successfully merging this pull request may close these issues.

3 participants