fix(jest/lib): template mutation with createSpyObject (#209)

Fix bug causing the template object to mutate when creating spy object for jest
ngneat · Oct 15, 2019 · e23af88 · e23af88
1 parent 093d0c9
commit e23af88
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/projects/spectator/jest/src/lib/mock.ts b/projects/spectator/jest/src/lib/mock.ts
@@ -7,7 +7,7 @@ export type SpyObject<T> = BaseSpyObject<T> & { [P in keyof T]: T[P] & (T[P] ext
  * @internal
  */
 export function createSpyObject<T>(type: InjectableType<T>, template?: Partial<Record<keyof T, any>>): SpyObject<T> {
- const mock: any = template || {};
+ const mock: any = { ...template } || {};
 
  installProtoMethods(mock, type.prototype, () => {
  const jestFn = jest.fn();

diff --git a/projects/spectator/jest/test/mock.spec.ts b/projects/spectator/jest/test/mock.spec.ts
@@ -0,0 +1,16 @@
+import { mockProvider } from '@ngneat/spectator/jest';
+
+import { WidgetService } from '../../test/widget.service';
+
+describe('mockProvider', () => {
+ it('should not modify the object passed in 2nd argument when running the mock factory', () => {
+ const customPropertiesAndMethods: Partial<Record<keyof WidgetService, any>> = {
+ testingProperty: 'overriden'
+ };
+ const { useFactory: factory } = mockProvider(WidgetService, customPropertiesAndMethods);
+ factory();
+ expect(customPropertiesAndMethods).toEqual({
+ testingProperty: 'overriden'
+ });
+ });
+});