Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse event helpers missing features #105

Closed
jsantha opened this issue May 7, 2019 · 2 comments
Closed

Mouse event helpers missing features #105

jsantha opened this issue May 7, 2019 · 2 comments

Comments

@jsantha
Copy link

jsantha commented May 7, 2019

Event object helpers for creating mouse events miss following features:

  • event bubbling
  • specifying mouse event button

Quick look at current implementation of Angular CDK library mouse event helpers shows that there is enabled event bubbling by default and you can explicitly specify a mouse button.

Spectator:
https:/NetanelBasal/spectator/blob/master/projects/spectator/src/lib/event-objects.ts#L4

CDK testing
https:/angular/components/blob/master/src/cdk/testing/event-objects.ts#L10

@jsantha
Copy link
Author

jsantha commented May 7, 2019

We need this line as well:
https:/angular/components/blob/master/src/cdk/testing/event-objects.ts#L31

Otherwise the mouseenter event is considered fake, see:
https:/angular/components/blob/master/src/cdk/a11y/fake-mousedown.ts

@NetanelBasal
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants