fix: fix query regression and unit testing improvements #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetanelBasal
approved these changes
Aug 8, 2019
| "test:jest": "npx ng run spectator-app:test-jest", | ||
| "test:jest:watch": "npx ng run spectator-app:test-jest --watch", |
There was a problem hiding this comment.
Why you removed the watch option?
There was a problem hiding this comment.
You can run both test and test:jest in watch mode with --watch so it felt a bit unneeded. ;-)
NetanelBasal
reviewed
Aug 8, 2019
| } | ||
|
|
||
| return child; | ||
| return _getChildren<R>(debugElementRoot)(directiveOrSelector, options)[0] || null; |
There was a problem hiding this comment.
I think we should at least add console info so that users will know what is missing.
There was a problem hiding this comment.
But that was before also not the case, right? Because the error was catched?
There was a problem hiding this comment.
Oh, sorry, I see. I'll fix it.
There was a problem hiding this comment.
Oh, well, it is still thrown right? Because it is not catched?
| @@ -5,6 +5,7 @@ import { Directive, EventEmitter, Type } from '@angular/core'; | |||
| * MockDirective({ selector: 'some-directive' }); | |||
| * MockDirective({ selector: 'some-directive', inputs: ['some-input', 'some-other-input'] }); | |||
| * | |||
| * @deprecated Deprecated in favour of the `ng-mocks` implementation of `MockDirective`. To be be removed in the next major version. | |||
|
@dirkluijk, please merge it to master and release a new version that fixes the regression. |
|
Of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, so I was a bit stubborn and decided to try to fix the regression.
In this PR:
SpectatorDebugElementNotFoundErrorerror which was thrown and catched immediately - but not in all cases. I removed the throw-and-catch mechanism in favour of a silent return ofnull(which is expected in all cases, especially for matchers liketoExist().projects/spectatorinstead ofsrc, I needed to move the "test" builder to thespectatorlibrary project. I did not move any test files around and decided to postpone a complete new test setup for a later moment (soon). For the current coverage, see the screenshot below.@deprecatedannotations for untested files.I think this fixes the issues in #147 as well. I'll take a look.
Closes #146 (added additional test case).
I don't see any issues anymore?