Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type definition for queryHostAll #230

Closed
undsoft opened this issue Nov 18, 2019 · 1 comment
Closed

Incorrect type definition for queryHostAll #230

undsoft opened this issue Nov 18, 2019 · 1 comment

Comments

@undsoft
Copy link

undsoft commented Nov 18, 2019

This type definition here:

public queryHostAll<R extends Element[]>(selector: string | DOMSelector, options?: { root: boolean }): R[];

produces double array (Element[][]) as a result.

It should be:

public queryHostAll<R extends Element>(selector: string | DOMSelector, options?: { root: boolean }): R[];

or

public queryHostAll<R extends Element[]>(selector: string | DOMSelector, options?: { root: boolean }): R;
@undsoft undsoft changed the title Incorrect type definition for quertyHostAll Incorrect type definition for queryHostAll Nov 18, 2019
@NetanelBasal
Copy link
Member

Do you want to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants