Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spectator): added directiveProviders to spectator-directive (#236) #240

Merged
merged 1 commit into from
Dec 3, 2019
Merged

feat(spectator): added directiveProviders to spectator-directive (#236) #240

merged 1 commit into from
Dec 3, 2019

Conversation

tamasfoldi
Copy link
Contributor

@tamasfoldi tamasfoldi commented Dec 3, 2019 •
edited
Loading 

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #236

What is the new behavior?

Now it is possible to override the directive providers with mocks or with own providers.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

NetanelBasal
NetanelBasal reviewed Dec 3, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
projects/spectator/test/directive-providers.directive.spec.ts Outdated Show resolved Hide resolved
@NetanelBasal NetanelBasal merged commit fd7ce10 into ngneat:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetanelBasal NetanelBasal Awaiting requested review from NetanelBasal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasfoldi @NetanelBasal