Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript: setRouteData should accept any type #498

Closed
myin142 opened this issue Oct 22, 2021 · 0 comments · Fixed by #504
Closed

Typescript: setRouteData should accept any type #498

myin142 opened this issue Oct 22, 2021 · 0 comments · Fixed by #504
Labels
good first issue Good for newcomers

Comments

@myin142
Copy link

myin142 commented Oct 22, 2021

Description

In the SpectatorRouting class, the methodsetRouteData value parameter should support any type since the normal Angular Route Data also accept any type.
Current solution is to cast the variable I want to use as any type. Everything else still works fine.

Proposed solution

set value parameter as any type

Alternatives considered

Or allow it to be generic.

Do you want to create a pull request?

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow passing any values to the Route#data
2 participants
@NetanelBasal @myin142