feat: allow providing ModuleTeardownOptions
#499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +37,8 @@ const defaultOptions: OptionalsRequired<BaseSpectatorOptions> = { | |||
| declarations: [], | |||
| imports: [], | |||
| schemas: [], | |||
| overrideModules: [] | |||
| overrideModules: [], | |||
| teardown: { destroyAfterEach: true } | |||
There was a problem hiding this comment.
Thanks for the PR.
I don't mind making it the default, but it should be considered a breaking change since we don't know the side effects it can cause.
Moreover, maybe we can use a global config flag to toggle this option globally.
There was a problem hiding this comment.
Let's make it as false since it's false by default in Angular 12, but it'll be true by default in 13?
|
@arturovt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.