fix: unpatch setTimeout before importing jQuery so it is not captured by zone.js
#571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Netanel.
I've been facing issues with
fakeAsyncand spectator during a long time, but I was thinking we're doing something wrong in unit tests. The issue has been happening so randomly, like in 1 of 10 cases, so I couldn't capture it. The tests were basically failing with1 timer(s) still in the queue.. So after debugging zone.jsonScheduleTaskI've found that the task, which is being scheduled, is$.ready.See the code:
https:/jquery/jquery/blob/5d5ea015114092c157311c4948f7cc3d8c8e7f8a/src/core/ready.js#L64-L70
I don't know if there's any other way to fix that issue and to force jquery not to schedule a timer. So I just unpatched the
setTimeoutbefore requiring jquery and then reset it back.