Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dom-spectator): add elem query with root opt for DOMSelector (#273) #277

Merged

Conversation

Coffee-Tea
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

You can use DOMSpectator methods query(), queryAll() and queryLast() with param root: true to get HTML element finding it in document.
But it works ONLY for string selectors (like <title> or .some-class etc.).
I've got cases and there is would be great to have the possibility to pass selector which are instances of DOMSelector class (like byText, byAltText etc., custom DOMSelector selectors).

Issue Number: #273

What is the new behavior?

Works as previously but also allow to use DOMSelector instances as selector querying with root: true param.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@NetanelBasal NetanelBasal merged commit 7409082 into ngneat:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants