feat(dom-spectator): add elem query with root opt for DOMSelector (#273) #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
You can use DOMSpectator methods
query()
,queryAll()
andqueryLast()
with paramroot: true
to get HTML element finding it indocument
.But it works ONLY for string selectors (like
<title>
or.some-class
etc.).I've got cases and there is would be great to have the possibility to pass selector which are instances of
DOMSelector
class (likebyText
,byAltText
etc., custom DOMSelector selectors).Issue Number: #273
What is the new behavior?
Works as previously but also allow to use DOMSelector instances as selector querying with
root: true
param.Does this PR introduce a breaking change?
Other information