bugfix(schematics): fix for angular 12 and align schematics #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelliott
reviewed
May 17, 2021
| * @param raw initial object | ||
| * @param keys list of keys to remove from object | ||
| */ | ||
| function _omit<T extends Record<string, any>>(raw: T, keys: (keyof T)[]): any { |
There was a problem hiding this comment.
Thanks for the PR. I think this function is doing the opposite of what you want it to!
There was a problem hiding this comment.
@benelliott is right. Check your filter logic.
| @@ -23,6 +23,7 @@ | |||
| "angular testing dumb components" | |||
| ], | |||
| "dependencies": { | |||
| "@angular-devkit/core": ">= 10.1.0", | |||
There was a problem hiding this comment.
Wenn I tried to run this as a linked package it complained that @angular-devkit/core was not found although it was installed in the project.
| @@ -21,7 +21,7 @@ import { ComponentOptions, DirectiveOptions, ServiceOptions } from './schema'; | |||
| export function spectatorComponentSchematic(options: ComponentOptions): Rule { | |||
| return chain([ | |||
| externalSchematic('@schematics/angular', 'component', { | |||
| ...options, | |||
| ..._omit(options, ['jest', 'withHost', 'withCustomHost']), | |||
There was a problem hiding this comment.
Angular 12 complains about options that are passed but not known
| * @param raw initial object | ||
| * @param keys list of keys to remove from object | ||
| */ | ||
| function _omit<T extends Record<string, any>>(raw: T, keys: (keyof T)[]): any { |
There was a problem hiding this comment.
@benelliott is right. Check your filter logic.
|
Thanks for the PR. See my comments, and please check that it works. |
DaSchTour
force-pushed
the
bugfix/angular-12-schematic-alignment
branch
from
cf640dd
to
584bdfd
Compare
|
I fixed the filter logic, but I'm not able to test because build is broken. |
Closed
DaSchTour
force-pushed
the
bugfix/angular-12-schematic-alignment
branch
from
584bdfd
to
3d1b088
Compare
|
@DaSchTour Can you clarify about the build being broken? Are you waiting on another issue to be resolved or just stuck on this fix because your changes broke the build and you don't know how to fix it? |
|
@cmplank I actually have now idea what this build issue is about. For me it looks completely unrelated. But I have no idea how to fix it and why it breaks. I just checked, the same issue is there on master. So it's not related to my changes. |
|
There is a PR |
|
Yeah, I see. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #434
What is the new behavior?
Added the type property and also improved the behavior for angular 12 which validates the input and breaks on unkown options
Does this PR introduce a breaking change?
Other information
Sadly I couldn't test it locally because the build broke because of some rxjs issues in ActivatedRouteStub