fix(Entity): Avoid for..in iteration in sorted state adapter (#805)

ngrx · Feb 11, 2018 · 4192645 · 4192645
1 parent 779d689
commit 4192645
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/modules/entity/spec/sorted_state_adapter.spec.ts b/modules/entity/spec/sorted_state_adapter.spec.ts
@@ -11,6 +11,20 @@ describe('Sorted State Adapter', () => {
  let adapter: EntityStateAdapter<BookModel>;
  let state: EntityState<BookModel>;
 
+ beforeAll(() => {
+ Object.defineProperty(Array.prototype, 'unwantedField', {
+ enumerable: true,
+ configurable: true,
+ value: 'This should not appear anywhere',
+ });
+ });
+
+ afterAll(() => {
+ Object.defineProperty(Array.prototype, 'unwantedField', {
+ value: undefined,
+ });
+ });
+
  beforeEach(() => {
  adapter = createEntityAdapter({
  selectId: (book: BookModel) => book.id,

diff --git a/modules/entity/src/sorted_state_adapter.ts b/modules/entity/src/sorted_state_adapter.ts
@@ -116,8 +116,7 @@ export function createSortedStateAdapter<T>(selectId: any, sort: any): any {
  const added: T[] = [];
  const updated: Update<T>[] = [];
 
- for (let index in updates) {
- const update = updates[index];
+ for (const update of updates) {
  if (update.id in state.entities) {
  updated.push(update);
  } else {