feat(Store): add an overload to createFeatureSelector to provide better type checking #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
requested changes
Jul 5, 2018
docs/store/selectors.md
Outdated
| @@ -104,6 +104,24 @@ export const selectFeatureCount = createSelector( | |||
| ); | |||
| ``` | |||
|
|
|||
| There is also an overload on the `createFeatureSelector` method, which allows a better typechecking. | |||
There was a problem hiding this comment.
Instead of adding this as an additional section, let's just make this the default in the example above.
There was a problem hiding this comment.
Yea I wasn't sure about this, but you just confirmed my thinking.
Should I also update the example app?
docs/store/selectors.md
Outdated
|
|
||
| Where `AppState` is the type from the top level feature state and `FeatureState` is the type from the feature slice to select. | ||
| Meaning that the following would not compile because `foo` is not a feature slice of `AppState`. | ||
|
|
There was a problem hiding this comment.
Keep the section starting with Meaning as a note.
brandonroberts
requested changes
Jul 5, 2018
docs/store/selectors.md
Outdated
| export const selectFeatureCount = createSelector( | ||
| selectFeature, | ||
| (state: FeatureState) => state.counter | ||
| ); | ||
| ``` | ||
|
|
||
| Meaning that the following would not compile because `foo` is not a feature slice of `AppState`. | ||
|
|
There was a problem hiding this comment.
Change to The following selector below would not ...
There was a problem hiding this comment.
No problem! Thanks for the reviews!
brandonroberts
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1136