Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics: Display provided path when displaying an error #1200

Closed
brandonroberts opened this issue Jul 27, 2018 · 3 comments
Closed

Schematics: Display provided path when displaying an error #1200

brandonroberts opened this issue Jul 27, 2018 · 3 comments

Comments

@brandonroberts
Copy link
Member

Describe any alternatives/workarounds you're currently using

Other information:

If accepted, I would be willing to submit a PR for this feature

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

If you provide an invalid path to a module or your reducers, the error doesn't provide any useful information about what path was constructed

@koumatsumoto
Copy link
Contributor

koumatsumoto commented Jul 28, 2018

Could I create a pull request for this feature?
I suppose points to update are below.

schematics-core/utility/find-module.ts

- throw new Error('Specified module does not exist');
+ throw new Error(`Specified module path ${modulePath} does not exist`);

schematics/src/effect/index.ts

- throw new Error('Specified module does not exist');
+ throw new Error(`Specified module path ${modulePath} does not exist`);

schematics/src/store/index.ts

- throw new Error('Specified module does not exist');
+ throw new Error(`Specified module path ${modulePath} does not exist`);

schematics-core/utility/ngrx-utils.ts

- throw new Error('Specified reducers path does not exist');
+ throw new Error(`Specified reducers path ${reducersPath} does not exist`);
- throw new Error('Specified module does not exist');
+ throw new Error(`Specified module path ${modulePath} does not exist`);

Thanks!

@brandonroberts
Copy link
Member Author

Absolutely

@koumatsumoto
Copy link
Contributor

@brandonroberts
I created a pull request for this issue.
Please review it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants