Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router-Store: Provide configuration for pre/post router navigation action #1263

Closed
brandonroberts opened this issue Aug 20, 2018 · 3 comments

Comments

@brandonroberts
Copy link
Member

Describe any alternatives/workarounds you're currently using

Other information:

If accepted, I would be willing to submit a PR for this feature

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

Currently, router-store dispatches a ROUTER_NAVIGATION action as a pre-activation hook which is run before guards and resolvers. We should provide an option to let this be configured to run as a post-activation hook that is run after guards and resolvers.

Also add an action that is dispatched when the navigation cycle ends successfully and the current route is active.

@dummdidumm
Copy link
Contributor

#1010 related

@dummdidumm
Copy link
Contributor

Looking at the angular router docs, there is not much in between "after guards and resolvers" and before "navigation end". There is ActivationEnd but that can be fired multiple times, resulting in multiple dispatched actions, same for ChildActivationEnd. After those two events, there is only NavigationEnd. So ROUTER_NAVIGATION will be dispatched at the same time like a possible ROUTER_NAVIGATED

@brandonroberts
Copy link
Member Author

Fixed via #1267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants