Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rewrite guides #1383

Closed
5 of 9 tasks
brandonroberts opened this issue Oct 26, 2018 · 12 comments
Closed
5 of 9 tasks

docs: Rewrite guides #1383

brandonroberts opened this issue Oct 26, 2018 · 12 comments

Comments

@brandonroberts
Copy link
Member

brandonroberts commented Oct 26, 2018

General

  • Architecture

@ngrx/store

  • Overview
  • Actions
  • Reducers
  • Selectors
  • Testing

@ngrx/effects

  • Overview
  • Effects
  • Testing

Other information:

Tracking these under a single issue rather than separate issues for each one.

@damienwebdev
Copy link

damienwebdev commented Nov 27, 2018

@brandonroberts do you need help with this one? We're refactoring our tests over in graycoreio/daffodil and one of our packages depends heavily on ngrx/store. I'd imagine with the new MockStore, you need docs covering this new feature and it's usage.

I'd be happy to chip in here if that would be useful.

@brandonroberts
Copy link
Member Author

@damienwebdev Yes, that would be great!

@simonh1000
Copy link

Could I suggest that you add an installation guide for the library as a whole, with schematics etc. I'm relying upon stuff on the internet but never know whether that is best practise

@nasreddineskandrani
Copy link
Contributor

nasreddineskandrani commented Dec 27, 2018

Hi,
I'll open one or multiple PR(s) to update the example-app with MockStore as stated in these comments
#1027 (comment)
I start working on it tomorow.


@brandonroberts
You said in this comment #1027 (comment)

All the test documentation will be updated to use the testing module. The testing guide will be updated with better documentation on testing.

MockStore can be used with the tests of effects and also the tests of components....
For this reason, should we separate the doc of MockStore from store, effects testing documentation to don't have to repeat things ...?

I think giving more details about how you see it exactly can help @damienwebdev to add the documentation.

@michahell
Copy link

To make sure that my request (making sure there is a part about completing and erroring out killing the observable, effectively) is not forgotten:
#1364

See also explanation in this article:
https://blog.angularindepth.com/5-tips-to-improve-user-experience-of-your-angular-app-with-ngrx-6e849ca99529

@brandonroberts
Copy link
Member Author

Thanks @michahell. There is a specific section in the effects guide that covers this https://ngrx.io/guide/effects#handling-errors

@michahell
Copy link

michahell commented Jan 30, 2019

ah, nice, I see :) okay moot point then!

@sgronblo
Copy link

Any plan to document State as part of this?

@brandonroberts
Copy link
Member Author

@sgronblo what do you mean? Document the API?

@sgronblo
Copy link

Hmm, I must have not been looking close enough yesterday. I was able to find State now. At least in the API section. There doesn't seem to be any mention about it in the "normal" documentation pages on ngrx.io though.

@timdeschryver
Copy link
Member

Do you mean this page @sgronblo ? If so, which part?

@sgronblo
Copy link

Not sure if this documentation feedback should go somewhere else, but here goes.

I was writing a service that needed to get a value from the Store. Realized that Store is an Observable and got worried that this could cause a problem where my service would not be able to get the required value from the Store until that value changes the next time. Lots of frantic googling finds a mix of different clues that ngrx also contains State which seems like it is same as Store except as a BehaviorSubject.

However, going to the actual ngrx.io site and trying to get a confirmation that my understanding is correct yields almost no information that State even exists. At least not in a way where it is easily found from the left menu on the document page. Eventually I found that State is in the API section here: https://ngrx.io/api/store/State but this page basically doesn't explain anything about whether there are any caveats to using it or whether I can just swap out the Store dependency to a State dependency and have everything work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants