Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Store): don't export internal functions and tokens #1679

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1657

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE:

Internal functions and tokens are removed from the public API

Other information

@brandonroberts
Copy link
Member

This needs a rebase

@brandonroberts brandonroberts added the Needs Cleanup Review changes needed label Apr 1, 2019
BREAKING CHANGE:

Internal functions and tokens are removed from the public API
@timdeschryver
Copy link
Member Author

@brandonroberts

@brandonroberts brandonroberts removed the Needs Cleanup Review changes needed label Apr 1, 2019
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 1, 2019

Preview docs changes for 189008a at https://previews.ngrx.io/pr1679-189008a/

@brandonroberts brandonroberts merged commit 0446a15 into master Apr 1, 2019
@brandonroberts brandonroberts deleted the pr/store-internal branch April 1, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store: Clean up public API
3 participants