Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): update ofType in effects per #1676 #1691

Merged
merged 1 commit into from
Apr 4, 2019
Merged

feat(example): update ofType in effects per #1676 #1691

merged 1 commit into from
Apr 4, 2019

Conversation

wesleygrimes
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1687

What is the new behavior?

Updates example application to match new action creator functionality of PR #1676

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 3, 2019

Preview docs changes for c39eefb at https://previews.ngrx.io/pr1691-c39eefb/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brandonroberts brandonroberts merged commit c9c9a0e into ngrx:master Apr 4, 2019
@KamranAsif KamranAsif mentioned this pull request Aug 23, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example: update ofType
4 participants