Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Disallow type to be passed to props of action creators #1917

Closed
alex-okrushko opened this issue Jun 5, 2019 · 0 comments · Fixed by #1923
Closed

RFC: Disallow type to be passed to props of action creators #1917

alex-okrushko opened this issue Jun 5, 2019 · 0 comments · Fixed by #1923
Assignees
@alex-okrushko
Labels
Project: Store

Comments

@alex-okrushko
Copy link
Member

type property would be overridden by the action creator itself, which could lead to time lost to debugging.

Describe any alternatives/workarounds you're currently using

Other information:

If accepted, I would be willing to submit a PR for this feature

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-okrushko alex-okrushko

Labels
Project: Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(store): add protection from type property use
1 participant
@alex-okrushko