Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: schematics should toggle immutability checks on by default #1950

Closed
timdeschryver opened this issue Jun 17, 2019 · 3 comments · Fixed by #1983
Closed

RFC: schematics should toggle immutability checks on by default #1950

timdeschryver opened this issue Jun 17, 2019 · 3 comments · Fixed by #1983
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Schematics

Comments

@timdeschryver
Copy link
Member

When using the schematics to create a root store, I think it would be a good practice to turn the immutability checks on.

runtimeChecks: {
        strictStateImmutability: true,
        strictActionImmutability: true,
},

And what about the serializability checks?

Describe any alternatives/workarounds you're currently using

Now the user needs to add it manually.
@brandonroberts
Copy link
Member

Good idea

@itayod
Copy link
Contributor

itayod commented Jun 28, 2019

@timdeschryver @brandonroberts I am available for this one.

@timdeschryver timdeschryver added Accepting PRs community watch Someone from the community is working this issue/PR labels Jun 28, 2019
@timdeschryver
Copy link
Member Author

Go for it @itayod

@itayod itayod mentioned this issue Jun 30, 2019
Merged
3 tasks
brandonroberts pushed a commit that referenced this issue Jul 1, 2019
@itayod @brandonroberts
feat(schematics): enable immutability checks for root store by default (
2b8178d 
#1983)

Closes #1950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Schematics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(schematics): toggle immutability checks for root by default itayod/platform
3 participants
@brandonroberts @itayod @timdeschryver