Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(effects): resubscribe every time and error occurs (#2023) #2026

Merged
merged 1 commit into from
Jul 23, 2019
Merged

fix(effects): resubscribe every time and error occurs (#2023) #2026

merged 1 commit into from
Jul 23, 2019

Conversation

peterreisz
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2023

What is the new behavior?

The effects will resubscribe every time an error occurs in the stream.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jul 20, 2019

Preview docs changes for 47f44d0 at https://previews.ngrx.io/pr2026-47f44d0/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jul 22, 2019

Preview docs changes for c491a9d at https://previews.ngrx.io/pr2026-c491a9d/

1 similar comment
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jul 22, 2019

Preview docs changes for c491a9d at https://previews.ngrx.io/pr2026-c491a9d/

timdeschryver
timdeschryver approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brandonroberts brandonroberts merged commit 5b48912 into ngrx:master Jul 23, 2019
brandonroberts added a commit that referenced this pull request Jul 31, 2019
@brandonroberts
Revert "fix(effects): resubscribe every time an error occurs (#2023) (#…
90dfecf 
…2026)"

This reverts commit 5b48912.
brandonroberts added a commit that referenced this pull request Jul 31, 2019
@brandonroberts
Revert "fix(effects): resubscribe every time an error occurs (#2023) (#…
14410c6 
…2026)" (#2037)

This reverts commit 5b48912.
@peterreisz
Copy link
Contributor Author

@brandonroberts @timdeschryver This PR was reverted due to some CI issue. Are you planning on fixing the issue? Can I help somehow?

@peterreisz peterreisz deleted the fix/2023-effects-resubscribe branch October 9, 2019 11:28
@timdeschryver timdeschryver mentioned this pull request Oct 14, 2019
Merged
3 tasks
@timdeschryver
Copy link
Member

@peterreisz see #2165

@peterreisz peterreisz restored the fix/2023-effects-resubscribe branch October 14, 2019 19:23
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
@jordanpowell88
fix(effects): resubscribe every time an error occurs (ngrx#2023) (ngr…
2cb1beb 
…x#2026)

Closes ngrx#2023
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
@brandonroberts @jordanpowell88
Revert "fix(effects): resubscribe every time an error occurs (ngrx#2023…
4a4bef6 
…) (ngrx#2026)" (ngrx#2037)

This reverts commit 5b48912.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts left review comments

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resubscribe on Error should work multiple times
4 participants
@peterreisz @ngrxbot @timdeschryver @brandonroberts