Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: Use minimal option by default for ng add #2250

Closed
brandonroberts opened this issue Nov 12, 2019 · 2 comments · Fixed by #2258
Closed

Store: Use minimal option by default for ng add #2250

brandonroberts opened this issue Nov 12, 2019 · 2 comments · Fixed by #2258
Assignees
@Jefiozie
Labels
Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Project: Store

Comments

@brandonroberts
Copy link
Member

brandonroberts commented Nov 12, 2019 •
edited
Loading

Change minimal to be true by default, so only the StoreModule.forRoot({}) is added to the AppModule.

The option is here: https:/ngrx/platform/blob/master/modules/store/schematics/ng-add/schema.json#L41
@Jefiozie
Copy link
Contributor

Hey @brandonroberts, I would like to pick this one up. Next to changing the property do you expect anything else?

@brandonroberts
Copy link
Member Author

The docs on the installation page may need updating also

@brandonroberts brandonroberts added the community watch Someone from the community is working this issue/PR label Nov 13, 2019
Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 13, 2019
@Jefiozie
refactor(schematics): Change minimal option to true by default
757576a 
Closes ngrx#2250
Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 13, 2019
@Jefiozie
docs(schematics): Describe how minimal flag works by using ng add
f59c90e 
Closes ngrx#2250
@Jefiozie Jefiozie mentioned this issue Nov 13, 2019
Merged
3 tasks
Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 13, 2019
@Jefiozie
refactor(schematics): Flag minimal is set to true
2dfc95a 
Closes ngrx#2250
Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 18, 2019
@Jefiozie
refactor(schematics): Flag minimal is set to true
54b14c0 
Closes ngrx#2250

BREAKING CHANGES:

With this change by default the minimal setup for `ngrx/store` will be generated.

BEFORE:

```
@NgModule({
  declarations: [
    AppComponent,
  ],
  imports: [
    BrowserModule,
    StoreModule.forRoot(reducers, {
      metaReducers,
      runtimeChecks: {
        strictStateImmutability: true,
        strictActionImmutability: true
      }
    }),
    .....
  ],
  providers: [],
  bootstrap: [AppComponent]
})
```

AFTER:

```
@NgModule({
  declarations: [
    AppComponent,
  ],
  imports: [
    BrowserModule,
    StoreModule.forRoot({})
    ....
  ],
  providers: [],
  bootstrap: [AppComponent]
})
```
brandonroberts pushed a commit that referenced this issue Jan 7, 2020
@Jefiozie @brandonroberts
refactor(schematics): Flag minimal is set to true (#2258)
7ecaa22 
Closes #2250

BREAKING CHANGES:

With this change by default the minimal setup for `@ngrx/store` will be generated.

BEFORE:

```
@NgModule({
  declarations: [
    AppComponent,
  ],
  imports: [
    BrowserModule,
    StoreModule.forRoot(reducers, {
      metaReducers,
      runtimeChecks: {
        strictStateImmutability: true,
        strictActionImmutability: true
      }
    }),
    .....
  ],
  providers: [],
  bootstrap: [AppComponent]
})
```

AFTER:

```
@NgModule({
  declarations: [
    AppComponent,
  ],
  imports: [
    BrowserModule,
    StoreModule.forRoot({})
    ....
  ],
  providers: [],
  bootstrap: [AppComponent]
})
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jefiozie Jefiozie

Labels
Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Project: Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor minimal option Jefiozie/platform
2 participants
@brandonroberts @Jefiozie