Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ngrx/data): correct AppEntityServices example in ngrx data doc page #2413

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

wardbell
Copy link
Contributor

closes #2280

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
DOCS ONLY

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior and new behavior?

The incorrect code example referred to NgRx Data as it used to be a long time ago. This PR brings the example up to date.

Closes #2280

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wardbell wardbell changed the title fix(ngrx/data): correct AppEntityServices example in ngrx data doc page docs(ngrx/data): correct AppEntityServices example in ngrx data doc page Feb 26, 2020
@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 26, 2020

Preview docs changes for 0faa6d9 at https://previews.ngrx.io/pr2413-0faa6d9/

@timdeschryver timdeschryver merged commit 711ba0e into ngrx:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngrx/data documentation for Sub-class EntityServices for application class convenience
3 participants