Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No logs about empty state for tests with mocked store #2513

Merged
merged 3 commits into from
May 12, 2020

Conversation

evgenyfedorenko
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

This code adds an internal setting and a setter for mock store environment.
When set it suppresses the logs about the state which does not exist.

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Console warn logs numerous logs for mocked store which should not happen

Closes #2363

What is the new behavior?

Logs will be suppressed

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This is a copy of #2420

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 6, 2020

Preview docs changes for 88c5511 at https://previews.ngrx.io/pr2513-88c5511/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts merged commit da1a0c0 into ngrx:master May 12, 2020
BioPhoton pushed a commit to BioPhoton/platform that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MockStore selectors resulting in warning logs
4 participants