Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component-store): selectors #2539

Merged
merged 3 commits into from
May 28, 2020
Merged

feat(component-store): selectors #2539

merged 3 commits into from
May 28, 2020

Conversation

alex-okrushko
Copy link
Member

@alex-okrushko alex-okrushko commented May 23, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Adding selector for ComponentStore. Includes debounceSync operator from rxjs-etc package, which requires a separate LICENSE adjustement.

Video overview of this PR is here:
https://youtu.be/n2fxNhY8KDQ

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 23, 2020

Preview docs changes for e980ab5 at https://previews.ngrx.io/pr2539-e980ab5/

@BioPhoton
Copy link
Contributor

Asked about comparing debounceSync with debounce.

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts merged commit 47e7ba3 into ngrx:master May 28, 2020
BioPhoton pushed a commit to BioPhoton/platform that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants