Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component-store): add imperative reads #2614

Merged
merged 2 commits into from
Jul 12, 2020
Merged

feat(component-store): add imperative reads #2614

merged 2 commits into from
Jul 12, 2020

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Add ability to read from ComponentStore imperatively.
It is set as protected to encourage its usage to be limited within a *Store that extends ComponentStore - and would contain all the business logic needed. Moreover, it's recommended to use get only within effects.

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Base automatically changed from cs-sync-selectors to master July 10, 2020 16:34
@timdeschryver
Copy link
Member

@alex-okrushko there are some conflicting changes here 😅

timdeschryver
timdeschryver approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/component-store/src/component-store.ts Outdated Show resolved Hide resolved
modules/component-store/src/component-store.ts Outdated Show resolved Hide resolved
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jul 12, 2020 •
edited
Loading

Preview docs changes for 0d67ea2 at https://previews.ngrx.io/pr2614-0d67ea27/

@brandonroberts brandonroberts merged commit 2146774 into master Jul 12, 2020
@brandonroberts brandonroberts deleted the cs-imperative-read branch July 12, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-okrushko @timdeschryver @ngrxbot @brandonroberts