Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document tapResponse #2811

Closed
timdeschryver opened this issue Dec 8, 2020 · 1 comment · Fixed by #2815
Closed

Document tapResponse #2811

timdeschryver opened this issue Dec 8, 2020 · 1 comment · Fixed by #2815
Labels
Comp: Docs Project: Component Store

Comments

@timdeschryver
Copy link
Member

Other information:

The tapResponse operator was introduced with #2763 but it's missing documentation.
I think it would be great if we had some example usage in our docs 🙂

I would be willing to submit a PR for the docs ❤️

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
@alex-okrushko
Copy link
Member

Missed this. Thanks for catching, Tim!

jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Dec 10, 2020
@jordanpowell88
docs(component-store): add docs for tapResponse operator
fd6ec34 
Closes ngrx#2811
@jordanpowell88 jordanpowell88 mentioned this issue Dec 10, 2020
Merged
3 tasks
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Dec 14, 2020
@jordanpowell88
docs(component-store): add docs for tapResponse operator
9186ec6 
Closes ngrx#2811
timdeschryver pushed a commit that referenced this issue Dec 15, 2020
@jordanpowell88
docs(component-store): add docs for tapResponse operator (#2815)
7f4e5ef 
Closes #2811
brandonroberts pushed a commit that referenced this issue Dec 15, 2020
@jordanpowell88 @brandonroberts
docs(component-store): add docs for tapResponse operator (#2815)
cd3492f 
Closes #2811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Comp: Docs Project: Component Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(component-store): add documentation for tapResponse operator jordanpowell88/platform
2 participants
@alex-okrushko @timdeschryver