Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct dist paths for testing packages #3249

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3248

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR changes the package.json from the testing (store and effects) packages.
Instead of setting the paths manually, the ng-packagr can do it for us - docs

After this change the output files look like this:

Store:

Before:

{
  "name": "@ngrx/store/testing",
  "typings": "ngrx-store-testing.d.ts",
  "main": "../bundles/core-testing.umd.js",
  "module": "../fesm2015/ngrx-store-testing.mjs",
  "es2015": "../fesm2015/testing.js",
  "esm5": "../esm5/testing/testing.js",
  "esm2015": "../esm2015/testing/testing.js",
  "fesm5": "../fesm5/testing.js",
  "fesm2015": "../fesm2015/ngrx-store-testing.mjs",
  "es2020": "../fesm2020/ngrx-store-testing.mjs",
  "esm2020": "../esm2020/testing/ngrx-store-testing.mjs",
  "fesm2020": "../fesm2020/ngrx-store-testing.mjs",
  "sideEffects": false
}

After:

{
  "module": "../fesm2015/ngrx-store-testing.mjs",
  "es2020": "../fesm2020/ngrx-store-testing.mjs",
  "esm2020": "../esm2020/testing/ngrx-store-testing.mjs",
  "fesm2020": "../fesm2020/ngrx-store-testing.mjs",
  "fesm2015": "../fesm2015/ngrx-store-testing.mjs",
  "typings": "ngrx-store-testing.d.ts",
  "sideEffects": false,
  "name": "@ngrx/store/testing"
}

Effects:

Before:

{
  "name": "@ngrx/effects/testing",
  "typings": "ngrx-effects-testing.d.ts",
  "main": "../bundles/core-testing.umd.js",
  "module": "../fesm2015/ngrx-effects-testing.mjs",
  "es2015": "../fesm2015/testing.js",
  "esm5": "../esm5/testing/testing.js",
  "esm2015": "../esm2015/testing/testing.js",
  "fesm5": "../fesm5/testing.js",
  "fesm2015": "../fesm2015/ngrx-effects-testing.mjs",
  "es2020": "../fesm2020/ngrx-effects-testing.mjs",
  "esm2020": "../esm2020/testing/ngrx-effects-testing.mjs",
  "fesm2020": "../fesm2020/ngrx-effects-testing.mjs",
  "sideEffects": false
}

After:

{
  "module": "../fesm2015/ngrx-effects-testing.mjs",
  "es2020": "../fesm2020/ngrx-effects-testing.mjs",
  "esm2020": "../esm2020/testing/ngrx-effects-testing.mjs",
  "fesm2020": "../fesm2020/ngrx-effects-testing.mjs",
  "fesm2015": "../fesm2015/ngrx-effects-testing.mjs",
  "typings": "ngrx-effects-testing.d.ts",
  "sideEffects": false,
  "name": "@ngrx/effects/testing"
}

@brandonroberts brandonroberts merged commit ed9f6f1 into master Nov 23, 2021
@brandonroberts brandonroberts deleted the fix/testing-dist-paths branch November 23, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: package.json of @ngrx/store/testing is incorrect
2 participants