Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): update installation of the NgRx ESLint Plugin #3259

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR updates the installation and the docs of the NgRx ESLint plugin.
An overview of the changes:

  • install v2 of the plugin, this is required for projects that use the latest version of the typescript plugin (installed with the Angular ESLint plugin)
  • the plugin has better configuration files, meaning that we can simply extend it now instead of configuring it manually
  • updated the config to make it consistent with the Angular ESLint plugin (we add a new override to the plugin instead of modifying an existing one)

@brandonroberts brandonroberts merged commit df211fe into master Dec 7, 2021
@timdeschryver timdeschryver deleted the update-eslint-plugin branch December 7, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants