Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effects): remove @Effect decorator #3634

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3617

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No
BREAKING CHANGE:

The @effect decorator is removed

BEFORE:
Defining an effect is done with @effect

@effect()

data$ = this.actions$.pipe();

AFTER:

Defining an effect is done with createEffect

data$ = createEffect(() => this.actions$.pipe());

Other information

BREAKING CHANGE:

The @effect decorator is removed

BEFORE:
Defining an effect is done with @effect

@effect()

data$ = this.actions$.pipe();

AFTER:

Defining an effect is done with createEffect

data$ = createEffect(() => this.actions$.pipe());
@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 81fce47
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/63596be9b26bfd0008d6d322
😎 Deploy Preview https://deploy-preview-3634--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌🏿🎉

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@markostanimirovic markostanimirovic merged commit 96c5bdd into master Oct 28, 2022
@markostanimirovic markostanimirovic deleted the feat/remove-effect-decorator branch October 28, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Effects: Remove Effect decorator
3 participants