Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): add withEffects feature for provideEntityData #3656

Merged

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There are two standalone functions for @ngrx/data package: provideEntityData and provideEntityDataWithoutEffects.

What is the new behavior?

There is only one standalone function for @ngrx/data package - provideEntityData.

When it's used in the following way:

provideEntityData({ entityMetadata });

It provides entity data with entity configuration without effects.

When it's used with withEffects feature as follows:

provideEntityData({ entityMetadata }, withEffects());

It also registers entity effects and provides HTTP data services.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

There are no breaking changes because standalone @ngrx/data APIs are not released yet.

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit baa7af4
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/636ad0832172a600093bb697
😎 Deploy Preview https://deploy-preview-3656--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@timdeschryver timdeschryver merged commit a6959e8 into ngrx:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants