Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-store): new selector factory selectRouteDataParam (#3673) #3686

Merged

Conversation

samuelfernandez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3673

What is the new behavior?

New selector factory for route data param

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Dec 1, 2022

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 483ed07
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6388d8e43d9df7000aeacd7b

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We should also update the docs https://ngrx.io/guide/router-store/selectors

@samuelfernandez
Copy link
Contributor Author

LGTM.

We should also update the docs https://ngrx.io/guide/router-store/selectors

@timdeschryver I checked that, and the only thing that changes as far as I've seen is the example already included in this PR. Those docs reference the example, but don't have explicit references

@timdeschryver
Copy link
Member

@samuelfernandez yep, you're right. My bad!

@brandonroberts brandonroberts merged commit 81bc0d9 into ngrx:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New selector factory for route data
3 participants