Replacing 'routerReducer' as an injectable token rather than static text

[phillipzada]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request

What is the current behavior?

Currently in router_store_module.ts routerReducer is a static text key.

Expected behavior:

Allow for the key name to be injected via a provider and token but defaulting to 'routerReducer' of not provided

Minimal reproduction of the problem with instructions:

Version of affected browser(s),operating system(s), npm, node and ngrx:

Other information:

Happy to put together a PR if approved.

[brandonroberts]

Seems reasonable to me. I would suggest adding a forRoot method that takes a config object with a key for the router reducer name. This way you don't have to register a new provider to override it.

[phillipzada]

Cool, so the end result will be something like this

StoreRouterConnectingModule.forRoot( { stateName: 'routerReducer' } );

[brandonroberts]

Yep. What about stateKey for the name?

[edmundo096]

This catched me by surprise. I used another name for the router state key and time traveling didn't worked on my first try.
After checking the example-app, I noticed the persistence on using the key 'routerReducer', so I checked the src and found that key. I gave it a try and it worked.

At least the setup code on the docs makes mention it in the StoreModule.forRoot({ routerReducer: routerReducer }), line, but maybe a note would be useful either if this is changed or not.

[pauldubois777]

@edmundo096 - Thanks for your post! This was driving me crazy trying to debug why time-traveling wasn't working! I tried a lot of things, and did a lot of searching for fixes until I found your post. I renamed the property to routerReducer and now it works!

I hope this can be fixed so that specific naming of the property isn't required, or at least update the documentation. I can help if needed.