Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Effects): Remove toPayload utility function #738

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

brandonroberts
Copy link
Member

BREAKING CHANGE: toPayload function is no longer exported

BEFORE:
import { toPayload } from '@ngrx/effects';

actions$.ofType('SOME_ACTION').map(toPayload);

AFTER:

actions$.ofType('SOME_ACTION').map((action: SomeActionWithPayload) => action.payload)

BREAKING CHANGE: toPayload function is no longer exported

BEFORE:

actions$.ofType('SOME_ACTION').map(toPayload);

AFTER:

actions$.ofType('SOME_ACTION').map((action: SomeActionWithPayload) => action.payload)
@MikeRyanDev MikeRyanDev merged commit b390ef5 into master Jan 22, 2018
@MikeRyanDev MikeRyanDev deleted the remove-to-payload branch January 22, 2018 04:17
@karptonite
Copy link
Contributor

Does this mean that there won't be another release until the next major release? Is a major release imminent? I was hoping for a patch release that included the fix in #570, as mentioned here. #570 (comment)

@MikeRyanDev
Copy link
Member

@karptonite Major release is imminent. Other than bumping the minimum version of RxJS and removing toPayload it should be a very straightforward upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants