feat(Entity): add removeMany by predicate #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great to me! I am going to label this at v6.x. We are in the middle of adding new infrastructure to support multiple versions in the same repo. Please don't be surprised if this takes some time to get merged. We have every intention of getting it into a release soon! |
|
@MikeRyanDev Should this change (and the update many from #907 - if approved) also be documented in the current docs? |
timdeschryver
force-pushed
the
pr/remove-many-predicate
branch
from
d75301a
to
6614500
Compare
|
@timdeschryver will you rebase this so it can land? |
timdeschryver
force-pushed
the
pr/remove-many-predicate
branch
from
6614500
to
fa04889
Compare
|
✔️ |
brandonroberts
requested changes
Oct 25, 2018
modules/entity/src/models.ts
Outdated
| @@ -38,6 +38,10 @@ export type UpdateNum<T> = { | |||
|
|
|||
| export type Update<T> = UpdateStr<T> | UpdateNum<T>; | |||
|
|
|||
| export type Predicate<T> = { | |||
There was a problem hiding this comment.
Make this the same as export type ComparerStr<T> = (a: T, b: T) => string;
timdeschryver
force-pushed
the
pr/remove-many-predicate
branch
from
fa04889
to
c3aba9d
Compare
|
Check! |
brandonroberts
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to remove entities based on a predicate.
See #672