-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EffectsModule breaks on RxJS6 #949
Comments
Why do you need ngrx/core ? I think this package has been removed since ngrx v4. |
@sandangel Good question lol... I'll remove it and see what happens :) Update - same issue. I wasn't using ngrx/core, it was just in my package.json for some reason. Thanks for pointing out that I can remove it. |
I have the same issue after upgrading to Ngrx 6.0.0-beta.0. However, it works if I run "ng serve --aot" instead of "ng serve". I found that workaround while searching previous related issues like #184 From what I understand, the Store module has to be loaded before loading other Ngrx modules, but for some reason the Store module is not found when running the app with the JIT compiler. With aot, the right module gets imported and the app runs without any problem in my case. |
same problem,
|
I think this is the first bug where it works correctly with AOT and incorrectly with JIT 🤨 |
I have created a simple project that reproduces the issue: https:/MakesNine/testapp Project works using "ng serve --aot" but doesn't work with "ng serve". |
@MakesNine thanks! https:/spock123/ngrx-effects-test I am NOT using the CLI but using a custom webpack build. Glad I'm not the only one with the issue, was going mad :) lol |
v6.0.0-beta.1 of NgRx has been released with a fix for this bug. |
When I am importing StoreModule in app module
Below error is coming, kindly help me to resolve this....
|
StoreModule.forRoot([ ]) |
Hi,
after upgrading to the 6.0.0 beta.0 I am having issues with the effects module.
Even the simplest effects module with an empty array of effects still gives the following error when importing the EffectsModule:
Notice the EffectsModule is called with no effects. If I remove the EffectsModule line everything works.
The error when including the EffectsModule is:
Dependencies:
Angular 6.0.0 RC.1
RxJS 6.0.0 RC.0
Ngrx/store, Ngrx/effects : 6.0.0-beta.0
Ngrx/core: 1.2.0 (now removed)
Typescript: 2.7.1 / 2.8.1
The text was updated successfully, but these errors were encountered: