Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): adjust mock store to handle selectors with props #1878

Merged
merged 2 commits into from
May 21, 2019
Merged

fix(store): adjust mock store to handle selectors with props #1878

merged 2 commits into from
May 21, 2019

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Mock store doesn't handle selectors with props

Closes # #1864

What is the new behavior?

Fixed it

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Refactored Mock Store tests out of store/spec
Added Bazel for it
Moved store/spec/fixtures into its own Bazel module
Added a number of tests for Mock Store
Added clean-up logic for Mock Store tests

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 21, 2019

Preview docs changes for 28c718d at https://previews.ngrx.io/pr1878-28c718d/

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 21, 2019

Preview docs changes for 555eaec at https://previews.ngrx.io/pr1878-555eaec/

@brandonroberts brandonroberts merged commit a7ded00 into ngrx:master May 21, 2019
@alex-okrushko alex-okrushko deleted the mock-store branch October 30, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants