Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data): fix compilation errors in example #2490

Merged
merged 1 commit into from
Apr 14, 2020
Merged

docs(data): fix compilation errors in example #2490

merged 1 commit into from
Apr 14, 2020

Conversation

LMFinney
Copy link
Contributor

The example code for "Replace the HttpUrlGenerator" has two errors:

  1. pluralizer is misspelled as pluralizzer once
  2. pluralizer needs to be something else to avoid conflicting with the private pluralizer property in the parent.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Compilation errors in a documentation example

Closes #

What is the new behavior?

Pasting the code into a project does not introduce a compilation error.

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

The example code for "Replace the HttpUrlGenerator" has two errors:

1. `pluralizer` is misspelled as `pluralizzer` once
2. `pluralizer` needs to be something else to avoid conflicting with the private `pluralizer` property in the parent.
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 13, 2020

Preview docs changes for b998ee4 at https://previews.ngrx.io/pr2490-b998ee4/

Copy link
Member

@alex-okrushko alex-okrushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@timdeschryver timdeschryver changed the title docs(data): Fix compilation errors in example docs(data): fix compilation errors in example Apr 14, 2020
@timdeschryver timdeschryver merged commit 1925308 into ngrx:master Apr 14, 2020
@timdeschryver
Copy link
Member

Thanks @LMFinney !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants