Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(schematics): replace deprecated TestBed.get #2503

Merged

Conversation

LayZeeDK
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The deprecated TestBed.get method is used in generated test suites.

Closes #2498

What is the new behavior?

The strongly typed TestBed.inject method is used in generated test suites.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Cc @timdeschryver

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 20, 2020

Preview docs changes for 0c15a79 at https://previews.ngrx.io/pr2503-0c15a79/

@LayZeeDK LayZeeDK force-pushed the schematics/replace-deprecated-testbed-get branch from 904c509 to 0c15a79 Compare April 20, 2020 20:36
@brandonroberts brandonroberts merged commit 9b2f05e into ngrx:master Apr 20, 2020
@brandonroberts
Copy link
Member

Thanks @LayZeeDK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schematics: effect schematic uses the deprecated TestBed.get
3 participants